forked from informalsystems/tendermint-rs
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix JSON deserialization of abci::ResponseInfo (informalsystems#1131)
* Fix JSON deserialization of abci::ResponseInfo The fields are annotated with json:"omitempty" in the Go source, so give them default values for Deserialize. The /abci_info endpoint is known to omit the app_version field in some recent revisions of Gaia. * Changelog entry for informalsystems#1131 * Annotate last_block_add_hash with serde(default) The only field of abci::ResponseInfo where it remained missing, to match the json:"omitempty" flag in Go. * rpc: Drop "std" feature from serde_json dependency * Revert "rpc: Drop "std" feature from serde_json dependency" This reverts commit 11396ba.
- Loading branch information
Showing
3 changed files
with
21 additions
and
4 deletions.
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
.changelog/unreleased/bug-fixes/1132-allow-omitted-fields-in-abci_info.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
- `[tools/proto-compiler]` Annotate serde to fall back to `Default` for the | ||
omitted fields when deserializing `tendermint_proto::abci::ResponseInfo` struct, | ||
also providing deserialization for the response at the `/abci_info` RPC endpoint. | ||
([#1132](https://github.com/informalsystems/tendermint-rs/issues/1132)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters