Helm chart creation #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love the amount of documentation in the helm charts. Great job Fedir! Do you think we should add a "helm lint" CI job? I think it might be valuable to make sure we don't break it if it's ever changed. |
tomsik68
reviewed
Feb 18, 2024
| image: "{{ .Values.xampp.containers.image.repository }}:{{ .Values.xampp.containers.image.tag | default .Chart.AppVersion }}" | ||
| imagePullPolicy: {{ .Values.xampp.containers.image.pullPolicy }} | ||
| {{- if ne .Values.xampp.containers.command "" }} | ||
| # command: ["dumb-init", "npm", "run", "start:demo"] |
There was a problem hiding this comment.
Let's get rid of commented out code here.
| repository: 'tomsik68/xampp' | ||
| pullPolicy: Always | ||
| tag: "8" | ||
| command: "" |
There was a problem hiding this comment.
This is probably just me not understanding helm, so please tell me if I'm wrong.
My current understanding is that this should be the same as the container's entrypoint - i.e. /usr/bin/supervisord -n.
How does it work if the command value is set to an empty string? Is there a default somewhere that I'm not seeing?
Co-authored-by: Tomáš Jašek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello this is initial Helm Chart for Xampp