Skip to content

Commit

Permalink
Replaces darwin with macos.
Browse files Browse the repository at this point in the history
Regression when adding --os. GOOS=darwin, but V8 calls it macos.
  • Loading branch information
tommie committed Dec 23, 2023
1 parent 0b43849 commit 7ad3da3
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/v8build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,13 @@ jobs:
arch: [x86_64, arm64]
include:
- os: android
v8os: android
platform: ubuntu-latest
- os: linux
v8os: linux
platform: ubuntu-latest
- os: darwin
v8os: macos
platform: macos-latest
runs-on: ${{ matrix.platform }}
steps:
Expand All @@ -35,10 +38,10 @@ jobs:
run: python3 -m ensurepip --default-pip && python3 -m pip install --upgrade setuptools
- name: Build V8 (${{ matrix.os }})
if: matrix.os == 'linux'
run: cd deps && ./build.py --no-clang --arch ${{ matrix.arch }} --os ${{ matrix.os }}
run: cd deps && ./build.py --no-clang --arch ${{ matrix.arch }} --os ${{ matrix.v8os }}
- name: Build V8 (${{ matrix.os }})
if: matrix.os == 'darwin' || matrix.os == 'android'
run: cd deps && ./build.py --arch ${{ matrix.arch }} --os ${{ matrix.os }}
run: cd deps && ./build.py --arch ${{ matrix.arch }} --os ${{ matrix.v8os }}
- name: Create PR
uses: peter-evans/create-pull-request@v3
with:
Expand Down

0 comments on commit 7ad3da3

Please sign in to comment.