Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Search bar implementation #439

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

Kabiirk
Copy link
Contributor

@Kabiirk Kabiirk commented Oct 26, 2024

Hi @tomlin7 ,

This closes Issue #409.

I've opted for a simple search logic that returns exact matches. Also searching for an empty string would give you the complete (initial) string as well.

Search feature can be triggered either by pressing the SEARCH icon in the top right (beside the REFRESH icon), or by pressing <ENTER> key after typing.

Copy link
Owner

@tomlin7 tomlin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks very clean! tested the feature and works well

@Kabiirk
Copy link
Contributor Author

Kabiirk commented Oct 26, 2024

Thanks ! Good to know

@tomlin7 tomlin7 merged commit 6684264 into tomlin7:main Oct 26, 2024
3 of 5 checks passed
@tomlin7
Copy link
Owner

tomlin7 commented Oct 26, 2024

@Kabiirk happy hacktoberfest! ❤️

@tomlin7 tomlin7 added the hacktoberfest-accepted Hacktoberfest accepted pr label Oct 26, 2024
@Kabiirk
Copy link
Contributor Author

Kabiirk commented Oct 26, 2024

@tomlin7
Happy Hacktoberfest to you too ! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest accepted pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants