Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blob, container: support for encryption scope #102

Merged
merged 1 commit into from
Feb 20, 2024
Merged

blob, container: support for encryption scope #102

merged 1 commit into from
Feb 20, 2024

Conversation

manicminer
Copy link
Collaborator

Supersedes #61

@manicminer manicminer requested a review from catriona-m February 8, 2024 12:31
@manicminer manicminer mentioned this pull request Feb 8, 2024
Closed
catriona-m
catriona-m approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to include encryption scope in some of the tests so we can be sure it works as expected, but otherwise this LGTM 👍

@manicminer manicminer merged commit b55c3a6 into main Feb 20, 2024
1 check passed
@manicminer manicminer deleted the f/encryption-scope branch February 20, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catriona-m catriona-m catriona-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @catriona-m