Custom error handler

CHANGELOG.md

@@ -8,6 +8,7 @@ Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) princip
 * [BC] DefaultHandler response code 404 instead 400
 * [BC] Added Container to API Decider
 * [BC] Output Configurator, Allows different methods for output configuration. Needs to be added to config services.
+* [BC] Error handler, Allows for custom error handling of handle method. Needs to be added to config services.
 * Query configurator rework
 
 #### Added

README.md

@@ -40,13 +40,20 @@ application:
     Api: Tomaj\NetteApi\Presenters\*Presenter
 ```
 
-Then register your preffered output configurator in *config.neon* services: 
+Register your preferred output configurator in *config.neon* services: 
 
 ```neon
 services:
     apiOutputConfigurator: Tomaj\NetteApi\Output\Configurator\DebuggerConfigurator
 ```
 
+Register your preferred error handler in *config.neon* services: 
+
+```neon
+services:
+    apiErrorHandler: Tomaj\NetteApi\Error\DefaultErrorHandler
+```
+
 And add route to you RouterFactory:
 
 ```php

src/Error/DefaultErrorHandler.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tomaj\NetteApi\Error;
+
+use Nette\Http\Response;
+use Throwable;
+use Tomaj\NetteApi\Output\Configurator\ConfiguratorInterface;
+use Tomaj\NetteApi\Response\JsonApiResponse;
+use Tracy\Debugger;
+
+final class DefaultErrorHandler implements ErrorHandlerInterface
+{
+    /** @var ConfiguratorInterface @inject */
+    public $outputConfigurator;
+
+    public function handle(Throwable $exception): JsonApiResponse
+    {
+        Debugger::log($exception, Debugger::EXCEPTION);
+        if ($this->outputConfigurator->showErrorDetail()) {
+            $response = new JsonApiResponse(Response::S500_INTERNAL_SERVER_ERROR, ['status' => 'error', 'message' => 'Internal server error', 'detail' => $exception->getMessage()]);
+        } else {
+            $response = new JsonApiResponse(Response::S500_INTERNAL_SERVER_ERROR, ['status' => 'error', 'message' => 'Internal server error']);
+        }
+        return $response;
+    }
+}

src/Error/ErrorHandlerInterface.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tomaj\NetteApi\Error;
+
+use Tomaj\NetteApi\Response\JsonApiResponse;
+use Throwable;
+
+interface ErrorHandlerInterface
+{
+    public function handle(Throwable $error): JsonApiResponse;
+}

src/Presenters/ApiPresenter.php

@@ -14,14 +14,15 @@
 use Tomaj\NetteApi\Api;
 use Tomaj\NetteApi\ApiDecider;
 use Tomaj\NetteApi\Authorization\ApiAuthorizationInterface;
+use Tomaj\NetteApi\Error\ErrorHandlerInterface;
 use Tomaj\NetteApi\Logger\ApiLoggerInterface;
 use Tomaj\NetteApi\Misc\IpDetectorInterface;
+use Tomaj\NetteApi\Output\Configurator\ConfiguratorInterface;
 use Tomaj\NetteApi\Output\OutputInterface;
 use Tomaj\NetteApi\Params\ParamsProcessor;
 use Tomaj\NetteApi\RateLimit\RateLimitInterface;
 use Tomaj\NetteApi\Response\JsonApiResponse;
 use Tracy\Debugger;
-use Tomaj\NetteApi\Output\Configurator\ConfiguratorInterface;
 
 final class ApiPresenter implements IPresenter
 {
@@ -37,6 +38,9 @@ final class ApiPresenter implements IPresenter
     /** @var ConfiguratorInterface @inject */
     public $outputConfigurator;
 
+    /** @var ErrorHandlerInterface @inject */
+    public $errorHandler;
+
     /**
      * CORS header settings
      *
@@ -121,13 +125,8 @@ public function run(Request $request): IResponse
                 }
             }
         } catch (Throwable $exception) {
-            if ($this->outputConfigurator->showErrorDetail()) {
-                $response = new JsonApiResponse(Response::S500_INTERNAL_SERVER_ERROR, ['status' => 'error', 'message' => 'Internal server error', 'detail' => $exception->getMessage()]);
-            } else {
-                $response = new JsonApiResponse(Response::S500_INTERNAL_SERVER_ERROR, ['status' => 'error', 'message' => 'Internal server error']);
-            }
+            $response = $this->errorHandler->handle($exception);
             $code = $response->getCode();
-            Debugger::log($exception, Debugger::EXCEPTION);
         }
 
         $end = microtime(true);