Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rmkit] update to all applications, add new apps: dumbskull, rpncalc and wordlet #542

Merged
merged 5 commits into from
Feb 9, 2022

Conversation

raisjn
Copy link
Contributor

@raisjn raisjn commented Jan 27, 2022

rmkit:

  • rmkit went through a large refactoring, so we update all apps
  • fix keyboard layout (swapped O and I keys originally)

dumbskull:

  • add new game, "Dumbskull", which is a themed solitaire

genie:

  • add palm rejection to genie (thakns Ekalfwons)

iago:

  • add settings dialog (@aeneas) that allows snapping

mines:

  • fix spurious crash when playing multiple games in a row

remux:

  • add dialog_height/dialog_width options to remux.conf
  • better memory analysis (of all processes in group, not just main process)
  • rm1: remove usb check that keeps it powered indefinitely

rpncalc:

  • add new app, rpncalc
  • add better spacing and layout
  • add push after operation behavior (next input is on new stack element)

wordlet:

  • add new game, "Wordlet", which is a wordle clone

@raisjn raisjn changed the title [rmkit] update to all applications, see changelog [rmkit] update to all applications, add two new apps: dumbskull and wordlet Jan 27, 2022
@raisjn raisjn changed the title [rmkit] update to all applications, add two new apps: dumbskull and wordlet [rmkit] update to all applications, add new apps: dumbskull, rpncalc and wordlet Jan 27, 2022
@raisjn
Copy link
Contributor Author

raisjn commented Jan 27, 2022

Tested installation and functionality on rM1:

  • bufshot - saved screenshot from CLI
  • dumbskull - loaded and clicked through a few games
  • genie, iago, lamp - drew circles, rect and line
  • harmony - loaded saved images from disk, drew a bit with the pen
  • mines - installable, can lose multiple games in a row
  • nao - can browse entware / toltec packages
  • remux - can see memory for all process types (including bash scripts)
  • rpncalc - tested a few simple operations, push, drop, etc
  • wordlet - played a single game

I have also individually tested each binary on rM2 (but not through the build artifacts)

@matteodelabre
Copy link
Member

I’ll test this later today. I’m eager to try out your Wordle clone :-)

@matteodelabre
Copy link
Member

Sorry for the delay. I went through the same testing process as you detailed in your previous message and most of it worked flawlessly! Here are some things I noticed:

  • rpncalc: conflicts with calculator on file /opt/etc/draft/icons/calculator.png (we should probably have an automated check for this kind of issue, pinging Add package lint tool build#12).
  • wordlet: I still see the keyboard letters “O” and “I” in the wrong order.
  • iago: are the settings saved somewhere? activating the “snap to grid” option doesn’t seem to persist across multiple executions of iago

* fix wordlet keyboard swapped letters
* move calculator.png -> rpncalc.png
@raisjn
Copy link
Contributor Author

raisjn commented Jan 29, 2022

thanks for the thorough testing! oof on wordlet's keyboard :-D i had fixed the swap on all apps with the normal keyboard but wordlet has a custom keyboard. iago settings are not persisting by design, but this is something we can look into

Fixed those the first two issues in rmkit-dev/rmkit@9375bb9 and rmkit-dev/rmkit@5005c3b

since this is a big set of changes for me (refactoring how inputs work, how display works, etc), i appreciate the thoroughness on testing

Copy link
Member

@LinusCDE LinusCDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did quick tests on both models. I really need to learn to play world. Only heard about it, but didn't get to learn/play it yet.

Other apps also seem fine. Didn't test iago and genie beyond basic installation though. So take this review with a grain of salt.

@raisjn raisjn merged commit c9d63bd into testing Feb 9, 2022
raisjn added a commit that referenced this pull request Feb 18, 2022
New Packages:

* Add new rmkit apps: dumbskull, rpncalc and wordlet (#542)
* Add package for Folly (z-machine interpreter) (#543)

Updated Packages:

* Update KOReader to v2022.01 (#517)
* Update innernet to 1.5.3 (#545)
* Update to all rmkit applications (#542)
* Update plato to 0.9.25 (#534)
* Update rm2fb to v0.0.14 (#552)

Misc:

* Remove outdated todo from opkg completion (#541)
@matteodelabre matteodelabre deleted the rmkit-update-01222022 branch February 21, 2022 04:43
matteodelabre added a commit that referenced this pull request Feb 21, 2022
* Update innernet timestamp
* Fix rmkit timestamp for apps updated in #542
* Patch the Plato wrapper script to make the process name be
  `/opt/bin/plato`, so that it can be properly recognized by remux
matteodelabre added a commit that referenced this pull request Feb 21, 2022
* Update innernet timestamp
* Fix rmkit timestamp for apps updated in #542
* Patch the Plato wrapper script to make the process name be
  `/opt/bin/plato`, so that it can be properly recognized by remux
raisjn added a commit that referenced this pull request Feb 21, 2022
* Stable merge for week 6 of 2022

New Packages:

* Add new rmkit apps: dumbskull, rpncalc and wordlet (#542)
* Add package for Folly (z-machine interpreter) (#543)

Updated Packages:

* Update KOReader to v2022.01 (#517)
* Update innernet to 1.5.3 (#545)
* Update to all rmkit applications (#542)
* Update plato to 0.9.25 (#534)
* Update rm2fb to v0.0.14 (#552)

Misc:

* Remove outdated todo from opkg completion (#541)

* Add hotfixes from #560

Co-authored-by: raisjn <[email protected]>
Co-authored-by: Mattéo Delabre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants