Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming upload/download support #139

Closed
julik opened this issue Sep 24, 2016 · 1 comment
Closed

Add streaming upload/download support #139

julik opened this issue Sep 24, 2016 · 1 comment

Comments

@julik
Copy link
Collaborator

julik commented Sep 24, 2016

It is tricky because currently we unlock the GIL for the entire duration of the request. However, if we make a branch for the case where streaming is desired, we could actually make the locks/unlocks more granular (per chunk).

I think it might be plausible to have streaming for both the request and response. For the response it would need separate methods (like get_streaming, put_streaming) when you want to deal with the response in a streaming fashion, and for the request we could have a convention of handling objects that are not Strings but do respond to each as iterator sources?..

@julik
Copy link
Collaborator Author

julik commented Feb 5, 2018

Continued in #158

@julik julik closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant