Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Patron and streaming #709

Closed
jcoyne opened this issue Jul 13, 2017 · 4 comments
Closed

Question: Patron and streaming #709

jcoyne opened this issue Jul 13, 2017 · 4 comments

Comments

@jcoyne
Copy link

jcoyne commented Jul 13, 2017

It has been explained to me in #620 that streaming is scheduled for 1.0, and that all adapters must be made to support it. However, Patron does not support streaming (toland/patron#139). Should we:

  1. Drop Patron as a supported adapter
  2. Change the expectation that all features must be supported by all drivers
@iMacTia
Copy link
Member

iMacTia commented Jul 13, 2017

@jcoyne I can see your point so let me rephrase what I said in #620 (comment).

We request contributors of new features to try making their features supported by all adapters. If an adapter is not capable of supporting that feature at all then, considering the importance of the feature and the interest from the community, the feature might still be added without support for that adapter.
This is a case-by-case decision, however I can see streaming being an important feature for the community, so this can be accepted if supported by most (but not all) adapters.

Again, this is clearly stated also in #485:

I have no experience with SOCKS, but to add a feature to an adapter in Faraday, the attempt must be made to add the same feature to all other adapters as well. Think you can look into it?

@iMacTia iMacTia closed this as completed Jul 13, 2017
@jcoyne
Copy link
Author

jcoyne commented Jul 13, 2017

@iMacTia Thanks for the clarification. Perhaps this policy could be moved into a README or CONTRIBUTING guide?

@iMacTia
Copy link
Member

iMacTia commented Jul 13, 2017

Totally agree with that. I just checked the CONTRIBUTING guide being sure I would find it, but I notice it was missing from there!
I'll add it straight away so hopefully I don't have to look for those comments again in the future

@iMacTia
Copy link
Member

iMacTia commented Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants