Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the UI class. #43

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Simplify the UI class. #43

merged 2 commits into from
Nov 23, 2023

Conversation

floitsch
Copy link
Member

No description provided.

@floitsch floitsch requested a review from kasperl November 22, 2023 19:47
Copy link
Member

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.


/** Whether the printer wants a structured representation for the given $kind. */
needs-structured --kind/int -> bool
/** Emits the given $json-object of the given message-$kind. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline here for consistency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

needs-structured --kind/int -> bool
/** Emits the given $json-object of the given message-$kind. */
emit-structured --kind/int json-object/any

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop one newline.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@floitsch floitsch enabled auto-merge (squash) November 23, 2023 14:53
@floitsch floitsch merged commit ccbd487 into main Nov 23, 2023
6 checks passed
@floitsch floitsch deleted the floitsch/simplify-ui branch November 23, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants