Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Furigana Firefox extension recommendation #96

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kyle-callert
Copy link

The old extension we recommended for Firefox has been updated/replaced by the same extension author with a new name of 10ten.

Changes proposed in this pull request:

  • Updated link and name to account for 10ten

The old extension we recommended for Firefox has been updated/replaced by the same extension author with a new name of 10ten.

I updated the link and name.
@kyle-callert kyle-callert requested a review from JenKay June 7, 2023 04:05
@netlify
Copy link

netlify bot commented Jun 7, 2023

Deploy preview succeeded. Preview with username: crabigator password: googlebegone

Name Link
🔨 Latest commit 5c62a37
🔍 Latest deploy log https://app.netlify.com/sites/wanikani-knowledgebase/deploys/66679952ed50260008643b56
😎 Deploy Preview https://deploy-preview-96--wanikani-knowledgebase.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vietqhoang
Copy link
Member

@JenKay, just a reping since I think this PR is waiting on a review.

@JenKay
Copy link

JenKay commented Jun 11, 2024

@vietqhoang Oh wow, completely missed this one. I just approved it but the branch is out of date with the base branch...which one do I click? "update with merge commit" or "update with rebase"?

@vietqhoang
Copy link
Member

@JenKay either works, but the more safer option would be to update with merge commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants