Also handle special characters (that need escaping) in the default ac…

…tion

Spaces, quotes, $, and other special shell characters need to be escaped inside the TODOTXT_DEFAULT_ACTION, and consequently eval() used to parse that back into individual arguments.

tests/t0002-actions.sh

@@ -18,7 +18,8 @@ chmod +x foo
 
 cat > foo2 << 'EOF'
 shift
-echo "TODO: $*"
+IFS=-
+printf 'TODO: %s\n' "$*"
 EOF
 chmod +x foo2
 
@@ -50,4 +51,19 @@ test_expect_success 'custom action (default action)' '
     test_cmp expect output && rm -rf .todo.actions.d
 '
 
+test_todo_session 'default custom action with multiple arguments' <<EOF
+>>> mkdir -p .todo.actions.d && cp foo2 .todo.actions.d/
+
+>>> TODOTXT_DEFAULT_ACTION='foo2 foo bar baz' todo.sh
+TODO: foo-bar-baz
+EOF
+
+export TODOTXT_DEFAULT_ACTION="foo2 foo\\ bar \\\$HOSTNAME O\\'Really\\? \\\"quoted\\\""
+test_todo_session 'default custom action with arguments that have special characters' <<EOF
+>>> mkdir -p .todo.actions.d && cp foo2 .todo.actions.d/
+
+>>> todo.sh
+TODO: foo bar-\$HOSTNAME-O'Really?-"quoted"
+EOF
+
 test_done

todo.sh

@@ -984,10 +984,11 @@ then
     exit $?
 else
     ## Use eventually given parameters
-    actionarray=($action)
-    if [ -d "$TODO_ACTIONS_DIR" -a -x "$TODO_ACTIONS_DIR/${actionarray[0]}" ]
+    eval "actionarray=($ACTION)"    # Note: Need to use original $ACTION to avoid that arguments are getting lowercased, too.
+    action=$( printf "%s\n" "${actionarray[0]}" | tr 'A-Z' 'a-z' )
+    if [ -d "$TODO_ACTIONS_DIR" -a -x "$TODO_ACTIONS_DIR/$action" ]
     then
-      "$TODO_ACTIONS_DIR/${actionarray[0]}" "${actionarray[@]}"
+      "$TODO_ACTIONS_DIR/$action" "${actionarray[@]}"
       exit $?
     fi
 fi