-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSPO Book] Content and Copy edits to PR "Final Review for chapter 4" #503
Conversation
Copy-edits for readability, and content added to tables with blank cells. Signed-off-by: Alice Sowerby <[email protected]>
Captializing some words, tense changes to headings Signed-off-by: Alice Sowerby <[email protected]>
✅ Deploy Preview for ospomindmap canceled.
|
✅ Deploy Preview for ospobook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Fixing changes suggested by @koozz Signed-off-by: Alice Sowerby <[email protected]>
@alice-sowerby Great work Alice! Thank you! PS: I've included in the description of this PR the details from the now duplicated PR here: #500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested adding the ✅ Assessment
💡 Recommendations
and tags in the TOC to follow the same format that also shows in other chapters + include OSPO mindmap link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Ana Jimenez Santamaria <[email protected]> Signed-off-by: Alice Sowerby <[email protected]>
Co-authored-by: Ana Jimenez Santamaria <[email protected]> Signed-off-by: Alice Sowerby <[email protected]>
Co-authored-by: Ana Jimenez Santamaria <[email protected]> Signed-off-by: Alice Sowerby <[email protected]>
Co-authored-by: Ana Jimenez Santamaria <[email protected]> Signed-off-by: Alice Sowerby <[email protected]>
@alice-sowerby besides changing emoji to custom icons open issue: Do you think this PR is ready to be merged? Are there any blockers on my end? |
@anajsana I think it's good to go! |
Copy edits to improve readability, and adding content to empty table cells.
Signed-off-by: Alice Sowerby [email protected]
AnaJS: Including the contributors that participated in the content creation of this PR: #500 and which are also included in this PR
These are changes that came from the final review during Chapter 4 meeting. During the call and the next two weeks, the changes were included using this docfor chapter intro and this doc for activity table
Contributors in this PR:
These people are also acknowledged in the OSPO Book contributors section.