Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSPO Book] Content and Copy edits to PR "Final Review for chapter 4" #503

Merged
merged 7 commits into from
Sep 14, 2024

Conversation

alice-sowerby
Copy link
Contributor

@alice-sowerby alice-sowerby commented Aug 19, 2024

Copy edits to improve readability, and adding content to empty table cells.

Signed-off-by: Alice Sowerby [email protected]

AnaJS: Including the contributors that participated in the content creation of this PR: #500 and which are also included in this PR

These are changes that came from the final review during Chapter 4 meeting. During the call and the next two weeks, the changes were included using this docfor chapter intro and this doc for activity table

Contributors in this PR:

  • Alice Sowerby
  • Cornelius Schumacher
  • Gergely Csatari
  • Ana Jiménez
  • Ulises Gascon
  • Jan van den Berg

These people are also acknowledged in the OSPO Book contributors section.

Copy-edits for readability, and content added to tables with blank cells. 

Signed-off-by: Alice Sowerby <[email protected]>
Captializing some words, tense changes to headings

Signed-off-by: Alice Sowerby <[email protected]>
@alice-sowerby alice-sowerby requested a review from a team as a code owner August 19, 2024 10:54
Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for ospomindmap canceled.

Name Link
🔨 Latest commit 581de68
🔍 Latest deploy log https://app.netlify.com/sites/ospomindmap/deploys/66e00180f262ad00081a6e10

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for ospobook ready!

Name Link
🔨 Latest commit 581de68
🔍 Latest deploy log https://app.netlify.com/sites/ospobook/deploys/66e001800724e9000814c31c
😎 Deploy Preview https://deploy-preview-503--ospobook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alice-sowerby alice-sowerby changed the title Alice Sowerby branch 1 Copy edits to PR "Final Review for chapter 4" Aug 20, 2024
Fixing changes suggested by @koozz 

Signed-off-by: Alice Sowerby <[email protected]>
@anajsana
Copy link
Member

anajsana commented Sep 2, 2024

@alice-sowerby Great work Alice! Thank you!

PS: I've included in the description of this PR the details from the now duplicated PR here: #500

Copy link
Member

@anajsana anajsana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested adding the ✅ Assessment 💡 Recommendations and tags in the TOC to follow the same format that also shows in other chapters + include OSPO mindmap link

ospo-book/content/en/04-chapter.md Outdated Show resolved Hide resolved
ospo-book/content/en/04-chapter.md Outdated Show resolved Hide resolved
ospo-book/content/en/04-chapter.md Outdated Show resolved Hide resolved
ospo-book/content/en/04-chapter.md Outdated Show resolved Hide resolved
@anajsana anajsana changed the title Copy edits to PR "Final Review for chapter 4" [OSPO Book] Content and Copy edits to PR "Final Review for chapter 4" Sep 2, 2024
@anajsana anajsana added the ospo-book issues related to ospo book project label Sep 2, 2024
Copy link
Member

@koozz koozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it visually stand out as a phase. Could be done later in another pull request too. This can be replaced at a later stage with one of the OSPO / TODO Group branded bars.

For example, this one:
image

ospo-book/content/en/04-chapter.md Show resolved Hide resolved
ospo-book/content/en/04-chapter.md Show resolved Hide resolved
ospo-book/content/en/04-chapter.md Show resolved Hide resolved
ospo-book/content/en/04-chapter.md Show resolved Hide resolved
alice-sowerby and others added 4 commits September 10, 2024 09:20
Co-authored-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Alice Sowerby <[email protected]>
Co-authored-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Alice Sowerby <[email protected]>
Co-authored-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Alice Sowerby <[email protected]>
Co-authored-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Alice Sowerby <[email protected]>
@alice-sowerby
Copy link
Contributor Author

@koozz @anajsana my understanding was that we wouldn't add emojis without an overall design from the designers?

@koozz
Copy link
Member

koozz commented Sep 10, 2024

@koozz @anajsana my understanding was that we wouldn't add emojis without an overall design from the designers?

That's OK 👍

@anajsana
Copy link
Member

@koozz @anajsana my understanding was that we wouldn't add emojis without an overall design from the designers?

Correct. But this might take time, so I'd suggest merging this and keeping the emoji. and then take care of replacing the emojis for the official icons, once this is ready

@anajsana
Copy link
Member

@alice-sowerby besides changing emoji to custom icons open issue: Do you think this PR is ready to be merged? Are there any blockers on my end?

@alice-sowerby
Copy link
Contributor Author

@anajsana I think it's good to go!

@anajsana anajsana merged commit 9400d96 into main Sep 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ospo-book issues related to ospo book project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants