[1861/1867] Restart major companies with 70% ownership limit in two-player games #11377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a major company is nationalised and then restarted it defaults to a 60% player ownership limit. This is wrong for the two-player variants, which allow a player to own up to 70% of a company. Fixes tobymao#11246.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Notes
If a major company is nationalised and then restarted it defaults to a 60% player ownership limit. This is wrong for the two-player variants, which allow a player to own up to 70% of a company.
Fixes #11246.
From testing, there is just one game that is broken after this patch is applied, game ID 147977 (there's an assumed pass when a player reaches 60% ownership in a merger round, which no long applies). This can be fixed by pinning or migrating.
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rake