Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1844] Must sell in blocks #11325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philcampeau
Copy link
Collaborator

Fixes #10824

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

As per screenshot of conversation with Helmut Ohley, players must sell shares in blocks.

I had to delete one of the fixture files, since it had an instance of selling multiple shares as separate actions.

Screenshots

Any Assumptions / Hacks

@philcampeau philcampeau added the pins PR that will require some games to be pinned label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pins PR that will require some games to be pinned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1844] Selling shares one at a time should not drop the price multiple times.
1 participant