Fixed #415

- Fixed UI issue on the HSTS toggle - Added error message on save error for HSTS
tobychui · Dec 6, 2024 · 24371ed · 24371ed
1 parent c39af1f
commit 24371ed
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/reverseproxy.go b/src/reverseproxy.go
@@ -1427,7 +1427,11 @@ func HandleHSTSState(w http.ResponseWriter, r *http.Request) {
 
 		if newMaxAge == 0 || newMaxAge >= 31536000 {
 			targetProxyEndpoint.HSTSMaxAge = int64(newMaxAge)
-			SaveReverseProxyConfig(targetProxyEndpoint)
+			err = SaveReverseProxyConfig(targetProxyEndpoint)
+			if err != nil {
+				utils.SendErrorResponse(w, "save HSTS state failed: "+err.Error())
+				return
+			}
 			targetProxyEndpoint.UpdateToRuntime()
 		} else {
 			utils.SendErrorResponse(w, "invalid max age given")

diff --git a/src/web/snippet/customHeaders.html b/src/web/snippet/customHeaders.html
@@ -364,7 +364,7 @@ <h4>Permission Policy</h4>
                             method: "POST",
                             data: {
                                 "domain": editingEndpoint.ep,
-                                "maxage": 31536000
+                                "maxage": HSTSEnabled?31536000:0,
                             },
                             success: function(data){
                                 if (data.error != undefined){