added MTLS external validation support #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tnorimat please Review |
|
@DmitryMishchuk Thank you. I will review this soon. |
tnorimat
reviewed
May 20, 2021
There was a problem hiding this comment.
@DmitryMishchuk I've reviewed this PR and add some review comments. Could you check them?
...rc/main/java/org/keycloak/protocol/oidc/representations/OIDCConfigurationRepresentation.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/keycloak/representations/oidc/OIDCClientRepresentation.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,13 @@ | |||
| package org.keycloak.mtls; | |||
There was a problem hiding this comment.
I'm not sure whether this provider is in server-spi project.
AFAIK, the providers in server-spi are fixed and never change their interfaces.
IMO, it might be appropriate that this provider be in server-spi-private.
It might be better to ask Keycloak development team about this point.
server-spi/src/main/java/org/keycloak/mtls/MtlsExtendedValidationSpi.java
Show resolved
Hide resolved
server-spi/src/main/java/org/keycloak/mtls/MtlsExtendedValidationProvider.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/keycloak/authentication/authenticators/client/X509ClientAuthenticator.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/keycloak/authentication/authenticators/client/X509ClientAuthenticator.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/keycloak/authentication/authenticators/client/X509ClientAuthenticator.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/keycloak/authentication/authenticators/client/X509ClientAuthenticator.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/keycloak/protocol/oidc/OIDCAdvancedConfigWrapper.java
Outdated
Show resolved
Hide resolved
tnorimat
pushed a commit
that referenced
this pull request
Jul 8, 2023
Closes keycloak/security#32 Co-authored-by: Stian Thorgersen <[email protected]> Conflicts: services/src/main/java/org/keycloak/protocol/oidc/grants/device/DeviceGrantType.java
tnorimat
pushed a commit
that referenced
this pull request
Feb 11, 2024
test: add test for nested disclosable jwt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MTLS external validation support as per keycloak/keycloak-community#267