refactor content files import into its own plugin. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update readme for this refactor. add example config json.
tnguyen14
reviewed
Jan 26, 2018
|
updated the tabs issue. |
tnguyen14
reviewed
Jan 26, 2018
| @@ -1,3 +1,4 @@ | |||
| node_modules | |||
| .DS_Store | |||
| .nyc_output | |||
| .vscode | |||
There was a problem hiding this comment.
You can add this to your ~/.gitignore so you don't have to add it for every project.
| helpersDir: 'templates/helpers' | ||
| }, | ||
| plugins: { | ||
| files: { |
There was a problem hiding this comment.
Can you discard all the changes in this file except for this part?
| @@ -5,14 +5,22 @@ const cpFile = require('cp-file'); | |||
| function copyImages (opts) { | |||
| return new Promise((resolve, reject) => { | |||
| // copy images | |||
| glob(opts.contentsDir + '/**/*.{jpg,png,svg}', (err, files) => { | |||
| glob(opts.files.contentsDir + '/**/*.{jpg,png,svg}', (err, files) => { | |||
There was a problem hiding this comment.
Should this be opts.plugins.files?
Also, it might make sense to have copyImages be part of the files plugin?
| } | ||
| }); | ||
| currentDir[file.filename] = file; | ||
| return Promise.all(plugins(opts.plugins, {})); |
There was a problem hiding this comment.
I think plugins() return a single promise, so no need to do Promise.all here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor content files import into its own plugin.
update readme for this refactor.
add example config json.
closes #29