Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: helpers.sh: use primary clipboard on wayland with mouse #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nunojsa
Copy link

@nunojsa nunojsa commented Jun 7, 2023

Follow the same logic as in X and use the primary clipboard for Wayland sessions when mouse support is on.

Note a new parameter (@yank_wayland_mouse), which is off by default, was introduced so that the old behavior is maintained. That means that users need to set the following in their tmux.conf:

set -g @yank_wayland_mouse 'true'

to enable the above behavior.

Follow the same logic as in X and use the primary clipboard for Wayland
sessions when mouse support is on.

Note a new parameter (@yank_wayland_mouse), which is off by default, was
introduced so that the old behavior is maintained. That means that users
need to set the following in their tmux.conf:

`set -g @yank_wayland_mouse 'true'`

to enable the above behavior.

Signed-off-by: Nuno Sa <[email protected]>
@nunojsa
Copy link
Author

nunojsa commented Jul 13, 2023

@bruno- @ctjhoa @jbnicolai can anyone give some feedback or is this not maintained anymore?

@anakimluke
Copy link

Hey! Thanks for the PR!
Why have a yank_wayland_mouse option in addition to yank_selection_mouse? I guess your reasoning is to keep backwards compatibility? I think it'd ok not to have it. Only people that have yank_selection_mouse set AND don't use it AND are on wayland would encounter different behaviour, if I understood correctly.

@nunojsa
Copy link
Author

nunojsa commented Sep 7, 2023

guess your reasoning is to keep backwards compatibility?

Exactly...

Only people that have yank_selection_mouse set AND don't use it AND are on wayland would encounter different behaviour, if I understood correctly.

Not sure about that. I think anyone using wayland with mouse will see different behavior. With this change wl-copy --primary will be used by default (assuming no option is given). And that is different from using wl-copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants