Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt grep -P to improve matches #135

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adopt grep -P to improve matches #135

wants to merge 2 commits into from

Conversation

oblitum
Copy link
Contributor

@oblitum oblitum commented Dec 18, 2018 •
edited
Loading

  • Fix support for matching quotes in URLs
  • Don't match whitespace before file paths
  • grep -P is needed

This solves one of the issues I've commented at:

I'm finally getting this all fixed! Locally at least :)

@oblitum oblitum mentioned this pull request Dec 18, 2018
Open
Adopt grep -P to improve matches
be123ba 
- Fix support for matching quotes in URLs
- Don't match whitespace before file paths
- grep -P is needed
@oblitum
Copy link
Contributor Author

oblitum commented Dec 25, 2018

Dunno why that single test fails on Travis, the test's match with message works on my machine. I've tried these changes on Linux and macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oblitum