Considering a "MediaOption" and "MultiSelect Option" #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 26, 2015 13:40
…how a preview, otherwise it'll show the media library URL
|
Hey @alcandelario, I obviously haven't kept this updated. Glad you're interested. I just merged in all the changes Automattic has made over the past few years. One of the things included is a multi checkbox option. I'll try to get some time to look at your MediaOption, as that sounds really cool. Cheers. |
|
Welp, let me update my fork to better conform to the changes from Automattic before you bother reviewing the MediaOption stuff :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I've found myself needing a MediaOption quite often - so change #1 is allowing users to select either an image or an arbitrary file from the Media Library (it's URL is saved in a hidden input). Change #2 to consider (maybe less useful) is the MultiOption, which allows users to choose multiple items that get saved as a serialized string.
If interested in suggesting any improvements, its much appreciated. Thanks for your work!