-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automattic's updates and new actions and method #5
Open
shawcohn
wants to merge
64
commits into
tmtrademark:master
Choose a base branch
from
shawcohn:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use we've moved the options setup/load out of the plugin.
…want them doing stupid things...
validation callback and new type of option
…ption and validation callback
…idental deletion of all settings
Updated readme and config-sample.php with explanation of validation_cb and new MultipleCheckboxesOption
Was creating a bug for Boolean options with a 0 default because the `! get_option( id )` would always return true. Both entries in the boolean dropdown would get the "selected" attribute.
…ctually a string instead of array. This check is needed to determine if a checkbox in a set of values for multiple checkboxes is selected but only one or no values were set, resulting options_checked variable being a string instead of an array. Cast to array before doing the check
…cap option" This reverts commit e858289. isset check doesn't really work in cheezcap_get_option
Fix a warning produced when second parameter for in_array check was actually a string instead of array. This check is needed to determine if a checkbox in a set of values for multiple checkboxes is selected but only one or no values were set, resulting options_checked variable being a string instead of an array. Cast to array before doing the check
…he handle_admin_actions function
…once within an array
…t the new actions and get_data method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the updates from Automattic's fork that make if WordPress.com VIP compatible. Also includes the addition of actions that can be hooked into using the "add_action" method and a new method that returns all of the options in one array.