Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keras callbacks #398

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Keras callbacks #398

wants to merge 2 commits into from

Conversation

jvpoulos
Copy link

@jvpoulos jvpoulos commented Oct 13, 2022

In Lrnr_lstm_keras and Lrnr_gru_keras, need to specify in fit() that callbacks is an element within args rather than an object. Without this change, the following error occurs when attempting to train either learner:

Error in normalize_callbacks_with_metrics(view_metrics, initial_epoch, : object 'callbacks' not found

For early stopping to work, we need to specify a validation set. The easiest way is to include a validation_split argument in fit(). The default of 0 would be no validation set.

@rachaelvp rachaelvp changed the base branch from master to devel October 14, 2022 19:12
@nhejazi
Copy link
Member

nhejazi commented Nov 11, 2022

thanks for contributing these changes @jvpoulos, and sorry for the delay in reviewing. @rachaelvp my suggestion would be to merge into devel and then fix on the backend (updating the actions file and removing devtools from Suggests); happy to help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants