Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement p2p prover and verifier #114

Merged
merged 17 commits into from
Nov 7, 2024
Merged

feat: implement p2p prover and verifier #114

merged 17 commits into from
Nov 7, 2024

Conversation

0xtsukino
Copy link
Collaborator

No description provided.

@0xtsukino 0xtsukino marked this pull request as ready for review November 4, 2024 09:28
@0xtsukino 0xtsukino requested review from Codetrauma and heeckhau and removed request for Codetrauma November 4, 2024 09:28
Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, huge change 😅

I could not test it yet, but I already left some comments

src/components/PluginList/index.tsx Show resolved Hide resolved
};

export const cancelPairRequest = async (target: string) => {
const { socket, clientId } = state;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of repetitive code here -> add function?

src/entries/Offscreen/Offscreen.tsx Outdated Show resolved Hide resolved
}): ReactElement {
return (
<button
className={classNames(
'flex flex-col flex-nowrap items-center justify-center',
'text-white px-2 py-1 gap-1 opacity-90 hover:opacity-100',
// {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented code?

@0xtsukino 0xtsukino merged commit 3989505 into main Nov 7, 2024
2 checks passed
@heeckhau heeckhau deleted the p2p-2 branch November 22, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants