Merge pull request #326 from tlsfuzzer/remove-extra-adds

Remove unnecessary adds from mul_add
tlsfuzzer · Sep 30, 2023 · fafbcaf · fafbcaf
2 parents 5a8ff7f + c3966c8
commit fafbcaf
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/ecdsa/ellipticcurve.py b/src/ecdsa/ellipticcurve.py
@@ -1008,8 +1008,8 @@ def mul_add(self, self_mul, other, other_mul):
         # so we need 4 combined points:
         mAmB_X, mAmB_Y, mAmB_Z = _add(X1, -Y1, Z1, X2, -Y2, Z2, p)
         pAmB_X, pAmB_Y, pAmB_Z = _add(X1, Y1, Z1, X2, -Y2, Z2, p)
-        mApB_X, mApB_Y, mApB_Z = _add(X1, -Y1, Z1, X2, Y2, Z2, p)
-        pApB_X, pApB_Y, pApB_Z = _add(X1, Y1, Z1, X2, Y2, Z2, p)
+        mApB_X, mApB_Y, mApB_Z = pAmB_X, -pAmB_Y, pAmB_Z
+        pApB_X, pApB_Y, pApB_Z = mAmB_X, -mAmB_Y, mAmB_Z
         # when the self and other sum to infinity, we need to add them
         # one by one to get correct result but as that's very unlikely to
         # happen in regular operation, we don't need to optimise this case