Add more logging for GoCardless rate limit information (actualbudget#…

…3895)
tlesicka · Dec 6, 2024 · 3ce7ae9 · 3ce7ae9
1 parent 1b25235
commit 3ce7ae9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/loot-core/src/server/accounts/sync.ts b/packages/loot-core/src/server/accounts/sync.ts
@@ -32,8 +32,8 @@ import { title } from './title';
 import { runRules } from './transaction-rules';
 import { batchUpdateTransactions } from './transactions';
 
-function BankSyncError(type: string, code: string) {
-  return { type: 'BankSyncError', category: type, code };
+function BankSyncError(type: string, code: string, details?: object) {
+  return { type: 'BankSyncError', category: type, code, details };
 }
 
 function makeSplitTransaction(trans, subtransactions) {
@@ -152,7 +152,11 @@ async function downloadGoCardlessTransactions(
   );
 
   if (res.error_code) {
-    throw BankSyncError(res.error_type, res.error_code);
+    const errorDetails = {
+      rateLimitHeaders: res.rateLimitHeaders,
+    };
+
+    throw BankSyncError(res.error_type, res.error_code, errorDetails);
   }
 
   if (includeBalance) {

diff --git a/upcoming-release-notes/3895.md b/upcoming-release-notes/3895.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [matt-fidd]
+---
+
+Add more logging for GoCardless rate limit information