-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to ignore deprecated fields #29
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otobuf into deprecated-spike
… <= v < 8.0.0 Updates the requirements on [jweir/elm-iso8601](https://github.com/jweir/elm-iso8601) to permit the latest version. - [Release notes](https://github.com/jweir/elm-iso8601/releases) - [Changelog](https://github.com/jweir/elm-iso8601/blob/master/CHANGES.md) - [Commits](jweir/elm-iso8601@5.0.0...7.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
…5.0.0lte-vlt-8.0.0
Wow, this is great, thanks for contributing! It will take me a while to review it, but I'll be happy to merge it as soon as I can! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a new protobuf plugin option to ignore all deprecated fields + messages.
--elm_opt=remove-deprecated
While implementing the new feature I refactored a bit as I went. The number of changes snowballed a
littlelotta bit.Driving Use Case
Deprecating an API field requires the removal of all references from the frontend codebase. It would be nice to rely on compile-time errors to enforce this required deprecation.
Example protobuf with deprecated fields + messages.
Breaking Changes
The change to the supported GO version technically makes this a backward-incompatible change. Not sure if that is important for the project as it is a standalone executable. Just in case that does matter, it might be nice to include a few other breaking changes before any new release.
oneof
values - the same solution for enums could be used (name collisions #8)New decoder is similar to
elm-json-decode-pipeline
solutionhttps://github.com/NoRedInk/elm-json-decode-pipeline/blob/1.0.0/src/Json/Decode/Pipeline.elm#L111