protoc-gen-elm: don't print input by default #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protoc-gen-elm no longer prints a text representation of the proto input
by default. To print the text representation, set the `debug` option:
protoc --elm_out=debug:. *.proto
Support for options is new. Even though `debug` is the only recognized
option for now, for future expansion we follow the convention of most
other protoc plugins by accepting a comma separated list of key=value
pairs (with optional value part).
protoc --elm_out=p1=v1,p2=v2,p3:. *.proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was taking protoc-gen-elm for a test-drive, and so far it's looking really good. Thank you very much for your work.
When generating elm code for an existing project, protoc-gen-elm printed thousands(!) of lines of what appears to be debug output, making the output from other protoc plugins completely invisible.
With this PR protoc-gen-elm no longer prints a text representation of the proto input
by default. To print the text representation, set the
debugoption:Support for options is new. Even though
debugis the only recognizedoption for now, for future expansion we follow the convention of most
other protoc plugins by accepting a comma separated list of key=value
pairs (with optional value part).