Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for MTLLibraryErrorDomain Code=1 "Invalid library file" #4373

Closed
wants to merge 4 commits into from
+3 −1
Closed

Fix for MTLLibraryErrorDomain Code=1 "Invalid library file" #4373

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20086f6
fix for MTLLibraryErrorDomain Code=1 "Invalid library file". using me…
mooihock May 1, 2024
606c306
removed old assertion for metal lib issue.
mooihock May 1, 2024
014b975
Merge branch 'master' into metal-fix
mooihock May 1, 2024
bd1ef42
Merge branch 'master' into metal-fix
mooihi May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tinygrad/runtime/ops_metal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ def __init__(self, device:MetalDevice, name:str, lib:bytes):
shader.write(lib)
shader.flush()
os.system(f"cd {pathlib.Path(__file__).parents[2]}/disassemblers/applegpu && python3 compiler_explorer.py {shader.name}")
assert lib[:4] == b"MTLB", "Invalid Metal library. Could be due to using conda. Try system python or METAL_XCODE=1 DISABLE_COMPILER_CACHE=1."
data = libdispatch.dispatch_data_create(lib, len(lib), None, None)
self.library = unwrap2(self.device.device.newLibraryWithData_error_(data, None))
self.fxn = self.library.newFunctionWithName_(name)
Expand Down Expand Up @@ -97,6 +96,9 @@ def __init__(self, device:str):
self.mtl_buffers_in_flight: List[Any] = []
self.mv_in_metal: List[memoryview] = []
self.track_cross_buffer: List[Any] = []
if getenv("CONDA_SHLVL") > 0:
os.environ["METAL_XCODE"] = "1"
print("Using Metal from Xcode SDK due to Conda targeting an unsupported macOS version(11.0).")
from tinygrad.runtime.graph.metal import MetalGraphRunner
super().__init__(device, MetalAllocator(self), MetalCompiler(None if getenv("METAL_XCODE") else self),
functools.partial(MetalProgram, self), MetalGraphRunner)
Expand Down