lora/lorawan: Further refactoring #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a driver for us 915 protocol to the lora WAN drivers.
…mbedded type named channel, do the same for RegionSettings, and then change RegionSettings to just Settings to avoid the redundant naming. Signed-off-by: deadprogram <[email protected]>
Closed
Signed-off-by: deadprogram <[email protected]>
any one of the supported regions at compile time by using ldflags. Signed-off-by: deadprogram <[email protected]>
deadprogram
force-pushed
the
lorawan-further-refactoring
branch
from
10bf7fe
to
c8c1676
Compare
|
Any further feedback on this @iamemilio @mirackara @soypat or anyone else? |
iamemilio
reviewed
Oct 22, 2023
|
Minor Nit pick, but overall LGTM. Much less code duplication |
|
Now merging, thanks for the work on #603 @iamemilio and @mirackara |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to perform further refactoring after #603 has been merged.