Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i2c legacy calls #589

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix i2c legacy calls #589

merged 1 commit into from
Aug 8, 2023

Conversation

kenbell
Copy link
Member

@kenbell kenbell commented Aug 7, 2023

Fix some uses of I2C WriteRegister that were causing make test to fail. (Side note: looks like CI isn't running make test)

@kenbell kenbell mentioned this pull request Aug 7, 2023
Merged
soypat
soypat approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@soypat soypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed these! Thanks for the PR. Looks good to me!

@deadprogram
Copy link
Member

Thanks for the fixes @kenbell now merging.

@deadprogram deadprogram merged commit 996f1b0 into dev Aug 8, 2023
1 check passed
@deadprogram deadprogram deleted the fix-i2c-legacy branch August 8, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soypat soypat soypat approved these changes

@deadprogram deadprogram Awaiting requested review from deadprogram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenbell @deadprogram @soypat