-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wifinina: add generated strings, improved debugging system and messages #560
Conversation
Signed-off-by: deadprogram <[email protected]>
With this PR:
|
The only drawback of this PR is that it does increase the resulting size by nearly 1.5k: Before this PR:
With this PR
|
Oof, that's a big increase! (I won't block this PR over the code size increase if you think it's worth it, just thinking of alternatives that might reduce the binary size somewhat). |
Signed-off-by: deadprogram <[email protected]>
OK, I just changed this to put most of the strings behind the Size before this PR:
This PR without the
This PR with the
|
Reopening since #537 will not merge until TinyGo 0.29 |
Since this is now only 450 bytes size increase in normal (non-debug) mode, I am going to merge. We really do need it. |
This PR adds generated strings, improved debugging system and improved error messages to the wifinina driver.