Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to uStreamer 6.11 #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update to uStreamer 6.11 #21

wants to merge 1 commit into from

Conversation

db39
Copy link
Contributor

@db39 db39 commented Apr 23, 2024

Resolves #19

uStreamer V6.11 appears to have performance and stability improvements. We've tested V6.11 against our manual video testing suite.

Review on CodeApprove

@db39 db39 marked this pull request as ready for review April 23, 2024 12:20
@db39 db39 requested a review from cghague April 23, 2024 12:20
Copy link
Contributor Author

db39 commented Apr 23, 2024

Automated comment from CodeApprove ➜

@cghague please review this Pull Request

Copy link

@cghague cghague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved

LGTM


In: Discussion
Suggest: Add a description to the pull request explaining why we've cut a release for this version and confirming what tests we've run.


👀 @db39 it's your turn please take a look

Copy link
Contributor Author

@db39 db39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

In: Discussion
Good idea, thanks!

I've tested V6.11 against our manual video tests, but I haven't measured video latency. I don't really have a suitable testbench for latency testing right now - is this something you can take on? I think it would make sense to test latency before cutting the release.


👀 @cghague it's your turn please take a look

Copy link

@cghague cghague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved


In: Discussion
I will have access to a suitable test environment once I return to my office, but that could be some time away. I'd recommend checking with the rest of the team so we don't delay the release.


👀 @db39 it's your turn please take a look

@db39
Copy link
Contributor Author

db39 commented May 29, 2024

Since the update to 6.11 isn't high-priority, we've decided to push back cutting the release until we can test latency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cut a release for uStreamer v6.11
2 participants