-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to uStreamer 6.11 #21
base: master
Are you sure you want to change the base?
Conversation
Automated comment from CodeApprove ➜⏳ @cghague please review this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
LGTM
In: Discussion
Suggest: Add a description to the pull request explaining why we've cut a release for this version and confirming what tests we've run.
👀 @db39 it's your turn please take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated comment from CodeApprove ➜
In: Discussion
Good idea, thanks!
I've tested V6.11 against our manual video tests, but I haven't measured video latency. I don't really have a suitable testbench for latency testing right now - is this something you can take on? I think it would make sense to test latency before cutting the release.
👀 @cghague it's your turn please take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
In: Discussion
I will have access to a suitable test environment once I return to my office, but that could be some time away. I'd recommend checking with the rest of the team so we don't delay the release.
👀 @db39 it's your turn please take a look
Since the update to 6.11 isn't high-priority, we've decided to push back cutting the release until we can test latency. |
Resolves #19
uStreamer V6.11 appears to have performance and stability improvements. We've tested V6.11 against our manual video testing suite.