Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add os-release file #177

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Add os-release file #177

merged 2 commits into from
Aug 16, 2023

Conversation

jacobweinstock
Copy link
Member

@jacobweinstock jacobweinstock commented Aug 13, 2023

Description

This allows us to know at runtime the version of HookOS. Also, modified the prompt to contain the version so that when sharing screenshots to debug it will be clear the Hook version.

Turned down the kernel.printk log level to warning (4) so that the console Getty doesn't get messy with kernel messages. Better UX (hopefully). A side effect of this is that we won't see messages anymore on the console when workflow action containers run. Syslog messages will still be sent to Boots.

image

Why is this needed

Fixes: #176

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This allows us to know at runtime the
version of HookOS. Also, modified the
prompt to contain the version so that
when sharing screenshots to debug it
will be clear the Hook version.

Turned down the kernel.printk log level
to warning (4) so that the console getty
doesn't get messy with kernel messages.
Better UX (hopefully). A side affect of this
is that we won't see messages anymore on the
console for when workflow action containers run.
Syslog messages will still be sent to Boots.

Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock changed the title Version file Add os-release file Aug 13, 2023
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Aug 16, 2023
@mergify mergify bot merged commit 1c438a9 into tinkerbell:main Aug 16, 2023
7 checks passed
@jacobweinstock jacobweinstock deleted the version-file branch August 16, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include a version file in Hook
2 participants