WIP: Dockerisation #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is where checkmate is pulled, or where repos are saved for instance, we don't want to cache it.
The site is able to run. We can register new users and new projects. The analysis is not run though. To do absolutely: - Have the data (repos and stats) in a separate container. - It's saved in `quantified/data` for now, but is configurable through config - Have the celery worker run (in a separate container?) - Command is `python manage.py runworker` Not breaking, but important, especially for scaling: - Be able to read a special config file - It's currently all hardcoded - Have RabbitMQ (or Redis) in a separate container - Have the database (postgres advised) in a separate container Both are almost ready but I couldn't get it to work properly. So I used the local version intead.
Some variables were undeclared or badly used
jlebonzec
force-pushed
the
jlebonzec/dockerisation
branch
from
2a94d77 to
f8ede65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The site is able to run. We can register new users and new projects.
The analysis can be run. But there is a problem in reading the output.
To do absolutely:
quantified/datafor now, but is configurable through configNot breaking, but important, especially for scaling: