invenio-communities: add facets for collections #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remileduc
commented
Aug 19, 2016
remileduc
commented
- see https://tindtechnologies.atlassian.net/browse/IN3-189
- we can manage each community with these permissions: - create - delete - manage the team - read - edit - curate
- possibility to add / remove users to the community - no more owner of the community: only different permissions
- we now have a link to community team management in "my communities" - added possibility to make a community public from the edition - better javascript bundle
- added the panel my communities in the new pages
- we can now suggest a record from a URL /communities/suggest/ - https://tindtechnologies.atlassian.net/browse/IN3-56
- fixed JS error on loading page - bad name of function, conflict with the one in invenio_theme for facets - added flash message when a record is accepted / rejected - use of namedtuple for the /team/ (more beautiful than inner class) - see https://tindtechnologies.atlassian.net/browse/IN3-65
- rebased on - rm logo in edit and new - added buttons in community box in index - icons in mycommunities box - hide text when no action create - change collection to community in the edit page - add button communities in the header - remove delete action from team management - more specific flash messages when suggest a record - see https://tindtechnologies.atlassian.net/browse/IN3-65
- add URL to tindeposit - fix issue when admin and can't see all the communities - see https://tindtechnologies.atlassian.net/browse/IN3-178
- add URL to tindeposit - fix issue when admin and can't see all the communities - see https://tindtechnologies.atlassian.net/browse/IN3-178
| <ul class="list-unstyled terms" ng-controller="FacetsShowMoreController"> | ||
| <li ng-repeat="subitem in item[subkey].buckets | limitTo: facetResults"> | ||
| <div class="checkbox checkbox-info checkbox-circle"> | ||
| <input id="checkbox-{{subitem.key}}" class="include-facet" type="checkbox" ng-checked="handler[subkey].indexOf(subitem.key) > -1" ng-click="!((handler[key].indexOf(item.key) > -1) !== (handler[subkey].indexOf(subitem.key) > -1)) && handleClick(key, item.key); handleClick(subkey, subitem.key)" /> |
There was a problem hiding this comment.
you know, angular is here to make simple and beautiful JS code (I love JS frameworks...)
so, globally, what it does... We have facets and subfacets, named "Volume" (top collection) and "Issue" (sub-collection). If you click on an issue facet, you want to search for this issue in the given volume.
So, if we have:
- Volume 1, Issue a
- Volume 1, Issue b
- Volume 2, Issue a
and you click on the first one, you want to search for issue a in volume 1, and not all issue a.
in the case volume 1 is already checked, we don't uncheck it, so we don't call the function "handleClick". Otherwise we do.
that's all :p
remileduc
force-pushed
the
remileduc/communities/integrate-facets
branch
from
245915a to
19819b8
Compare
|
@remileduc and the filtering works too? |
|
👌 |
|
yes they do thanks to the big condition :p |
remileduc
force-pushed
the
tind-master
branch
2 times, most recently
from
02ce83b to
14b5ca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.