Give all HTML button elements a type

The HTML button elements we use are all regular buttons that don't submit form data to a server. According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#notes those buttons should all have their type set to `button` explicitly, but we only do that a handful of them. This commit fixes the issue by consistently giving all our buttons the `button` type. Co-authored-by: Calixte Denizet <[email protected]>
timvandermeij · Jul 30, 2024 · f1f58bb · f1f58bb
1 parent 8f45374
commit f1f58bb
Show file tree

Hide file tree

Showing 5 changed files with 58 additions and 58 deletions.
diff --git a/examples/learning/prevnext.html b/examples/learning/prevnext.html
@@ -9,8 +9,8 @@
 <h1>'Previous/Next' example</h1>
 
 <div>
-  <button id="prev">Previous</button>
-  <button id="next">Next</button>
+  <button id="prev" type="button">Previous</button>
+  <button id="next" type="button">Next</button>
   &nbsp; &nbsp;
   <span>Page: <span id="page_num"></span> / <span id="page_count"></span></span>
 </div>

diff --git a/examples/mobile-viewer/viewer.html b/examples/mobile-viewer/viewer.html
@@ -43,13 +43,13 @@ <h1 id="title"></h1>
     </div>
 
     <footer>
-      <button class="toolbarButton pageUp" title="Previous Page" id="previous"></button>
-      <button class="toolbarButton pageDown" title="Next Page" id="next"></button>
+      <button class="toolbarButton pageUp" title="Previous Page" id="previous" type="button"></button>
+      <button class="toolbarButton pageDown" title="Next Page" id="next" type="button"></button>
 
       <input type="number" id="pageNumber" class="toolbarField pageNumber" value="1" size="4" min="1">
 
-      <button class="toolbarButton zoomOut" title="Zoom Out" id="zoomOut"></button>
-      <button class="toolbarButton zoomIn" title="Zoom In" id="zoomIn"></button>
+      <button class="toolbarButton zoomOut" title="Zoom Out" id="zoomOut" type="button"></button>
+      <button class="toolbarButton zoomIn" title="Zoom In" id="zoomIn" type="button"></button>
     </footer>
 
      <script src="viewer.mjs" type="module"></script>

diff --git a/extensions/chromium/options/options.html b/extensions/chromium/options/options.html
@@ -31,7 +31,7 @@
 </head>
 <body>
 <div id="settings-boxes"></div>
-<button id="reset-button">Restore default settings</button>
+<button id="reset-button" type="button">Restore default settings</button>
 
 <template id="checkbox-template">
 <!-- Chromium's style: //src/extensions/renderer/resources/extension.css -->

diff --git a/web/viewer-geckoview.html b/web/viewer-geckoview.html
@@ -99,7 +99,7 @@
       <div id="mainContainer">
 
         <div id="floatingToolbar">
-          <button id="download" class="toolbarButton" title="Download" tabindex="31" data-l10n-id="pdfjs-download-button">
+          <button id="download" class="toolbarButton" type="button" title="Download" tabindex="31" data-l10n-id="pdfjs-download-button">
             <span data-l10n-id="pdfjs-download-button-label">Download</span>
           </button>
         </div>
@@ -118,8 +118,8 @@
             <input type="password" id="password" class="toolbarField">
           </div>
           <div class="buttonRow">
-            <button id="passwordCancel" class="dialogButton"><span data-l10n-id="pdfjs-password-cancel-button">Cancel</span></button>
-            <button id="passwordSubmit" class="dialogButton"><span data-l10n-id="pdfjs-password-ok-button">OK</span></button>
+            <button id="passwordCancel" class="dialogButton" type="button"><span data-l10n-id="pdfjs-password-cancel-button">Cancel</span></button>
+            <button id="passwordSubmit" class="dialogButton" type="button"><span data-l10n-id="pdfjs-password-ok-button">OK</span></button>
           </div>
         </dialog>
       </div>  <!-- dialogContainer -->