Merge pull request mozilla#17657 from Snuffleupagus/eslint-jasmine-no…

…-dupes Prevent duplicate names in unit/integration tests
timvandermeij · Feb 11, 2024 · 4b7382e · 4b7382e
2 parents 422e46d + 5732fae
commit 4b7382e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/test/.eslintrc b/test/.eslintrc
@@ -10,8 +10,8 @@
     "jasmine/new-line-between-declarations": "off",
     "jasmine/no-focused-tests": "error",
     "jasmine/no-pending-tests": "off",
-    "jasmine/no-spec-dupes": "off",
-    "jasmine/no-suite-dupes": "off",
+    "jasmine/no-spec-dupes": ["error", "branch"],
+    "jasmine/no-suite-dupes": ["error", "branch"],
     "jasmine/prefer-jasmine-matcher": "off",
     "jasmine/prefer-toHaveBeenCalledWith": "off"
   }

diff --git a/test/integration/find_spec.mjs b/test/integration/find_spec.mjs
@@ -72,7 +72,8 @@ describe("find bar", () => {
       );
     });
   });
-  describe("highlight all", () => {
+
+  describe("highlight all (XFA)", () => {
     let pages;
 
     beforeAll(async () => {

diff --git a/test/unit/scripting_spec.js b/test/unit/scripting_spec.js
@@ -999,7 +999,7 @@ describe("Scripting", function () {
         });
       });
 
-      it("should format a date", async () => {
+      it("should format a date (cFormat)", async () => {
         const refId = getId();
         const data = {
           objects: {

diff --git a/test/unit/xfa_parser_spec.js b/test/unit/xfa_parser_spec.js
@@ -1021,7 +1021,7 @@ describe("XFAParser", function () {
       ).toBe("SW1");
     });
 
-    it("should make basic binding with extra subform", function () {
+    it("should make basic binding with extra subform (consumeData)", function () {
       const xml = `
 <?xml version="1.0"?>
 <xdp:xdp xmlns:xdp="http://ns.adobe.com/xdp/">