Improve the webserver's constructor

This makes the webserver configurable during instantiation rather than having to set the parameters afterwards.
timvandermeij · Feb 17, 2024 · 2e6fa79 · 2e6fa79
1 parent 985ba77
commit 2e6fa79
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/gulpfile.mjs b/gulpfile.mjs
@@ -2068,8 +2068,7 @@ gulp.task(
       console.log("### Starting local server");
 
       const { WebServer } = await import("./test/webserver.mjs");
-      const server = new WebServer();
-      server.port = 8888;
+      const server = new WebServer({ port: 8888 });
       server.start();
     }
   )

diff --git a/test/test.mjs b/test/test.mjs
@@ -1015,11 +1015,12 @@ async function startBrowsers({ baseUrl, initializeSession }) {
 }
 
 function startServer() {
-  server = new WebServer();
-  server.host = host;
-  server.port = options.port;
-  server.root = "..";
-  server.cacheExpirationTime = 3600;
+  server = new WebServer({
+    root: "..",
+    host,
+    port: options.port,
+    cacheExpirationTime: 3600,
+  });
   server.start();
 }
 

diff --git a/test/webserver.mjs b/test/webserver.mjs
@@ -38,13 +38,13 @@ const MIME_TYPES = {
 const DEFAULT_MIME_TYPE = "application/octet-stream";
 
 class WebServer {
-  constructor() {
-    this.root = ".";
-    this.host = "localhost";
-    this.port = 0;
+  constructor({ root, host, port, cacheExpirationTime }) {
+    this.root = root || ".";
+    this.host = host || "localhost";
+    this.port = port || 0;
     this.server = null;
     this.verbose = false;
-    this.cacheExpirationTime = 0;
+    this.cacheExpirationTime = cacheExpirationTime || 0;
     this.disableRangeRequests = false;
     this.hooks = {
       GET: [crossOriginHandler],