Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Required.Proto2.JsonInput.AllFieldAcceptNull conformance #653

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix Required.Proto2.JsonInput.AllFieldAcceptNull conformance #653

merged 1 commit into from
Jul 8, 2024

Conversation

jcready
Copy link
Contributor

@jcready jcready commented Jul 4, 2024

A new requirement for protobuf conformance is that all fields in the proto2 JSON representation accept/ignore null values. This change ensures protobuf-ts is passing 100% of the required conformance tests.

timostamm
timostamm approved these changes Jul 8, 2024
View reviewed changes
Copy link
Owner

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @jcready!

This doesn't handle JSON null completely (merging into an existing message should reset the field), but it's clearly a great improvement. LGTM!

@timostamm timostamm merged commit 91917f6 into timostamm:main Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcready @timostamm