Prevent unused types warnings

[danielvandenberg95]

Prevent typescript unused types warnings by prefixing unused types with _.

[danielvandenberg95]

This may have to happen in more places, these are just the ones I ran into.

[timostamm]

Thanks for the PR!

The TypeScript compiler has many options, and sometimes makes breaking changes in minor releases. That's why we have the ts_nocheck option.

So I'm hesitant to make complicated amends in the code generator. Especially since I really want to move away from the TS Compiler API to generate code, and switch to @bufbuild/protoplugin for easier maintenance.

That said, this is not a complicated change in the code generator 🙂

This may have to happen in more places, these are just the ones I ran into.

Could you run your type check against code generated from the proto directory?

[danielvandenberg95]

Oh, I actually had overlooked that option, because //tslint:disable was already in there and didn't work. As it'll become the default in the next release, to be honest I'd think this commit a bit of a waste. Using that option now, seems a lot better.

(And to be fair, the empty ? "_smth" : "smth" was bugging me a bit... Didn't like this solution all too much...)