Add support for custom options on: oneofs, enums, and enum values #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcready
commented
Aug 5, 2023
| @@ -37,6 +37,9 @@ import type {JsonValue} from "./json-typings"; | |||
| * Because the JSON format requires the original value name, we store the | |||
| * dropped prefix here, so that the JSON format implementation can restore | |||
| * the original value names. | |||
| * | |||
| * | |||
| * [3] the options for the enum and enum values (optional) | |||
| */ | |||
| export type EnumInfo = readonly [ | |||
There was a problem hiding this comment.
This is a rather unfortunate structure compared to the MessageInfo. Maybe in v3 this can be updated to an object instead of an array/tuple.
|
May I know the latest status of this PR? I think these cool changes can bring benefits to many projects. I am trying to add description text by enum value options for some protobuf enum defined for objects status, and I read these options value in order to show on pages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #37 and #537