-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README, and bugfixes for running on Windows #13
base: main
Are you sure you want to change the base?
Conversation
- empty line process, skip the loop instead of printing "error".
- Change file name format, avoid ":" in it.
- Update the windows specific-requirements infomation.
- Update the windows specific-requirements infomation.
Hi! Thanks for the PR. Sorry, I have had a lot on my plate, and I forgot to get back to this PR. I'm working on fixing another of my libraries at the moment but will try to come to this PR afterwards. I still don't have a windows machine, so I can't validate what you wrote in your readme. If its ok, I'd like to include it next to the previous advice about using cygwin--and users can perhaps try one or both approaches. I'll try to validate the two bug fixes you included as well. Thanks for the PR! |
I'm sorry that its taken me so long to get around to this PR. I know this question comes super late, but can you describe the bugs that you encountered? I hesitate to apply these changes, especially when other windows users haven't needed to apply them. |
Sorry for responding so late. I'm no longer working on this project, so I can only recall what problems I encountered from the commit messages. I'm not sure how other Windows users have gotten through the process without any problems, perhaps they used a Bash environment such as MinTTY to finish the process? Idk. I'm not sure if I'm capable to continue refining this PR, due to time and work problems. So if you think my modifications aren't enough or something is not right, you can reject this PR and then revise it your way. |
Thank you for the detailed response. I will try to take a look at this over the weekend and will try to get it merged. Thank you again! |
Please check my changes before merging.