Support for tweet-threads and related changes #64
Conversation
- Omit the horizontal rule between tweets where one is a reply to the previous tweet - Add an anchor to each tweet - Remove the "Replying to" header - instead, link @NAMEs to the tweet (on twitter) being replied to - When outputting replies to self that don't immediately follow the tweet being replied to, print an up arrow ↑ that links to the anchor of the previous tweet in the thread - When outputting a tweet that has replies that don't immediately follow, print down arrows ↓ that link to the anchor of each reply (I'm not sure of the method of linking is actually useful - id's and filenames are valid, but may need to be expressed differently to work as intended in practice)
| md_string += '\n\n----\n' if md_string else '' | ||
| if(t.reply_to_self): | ||
| # a reply-to-self, but not a reply to the most recently output tweet: add a header | ||
| md_string += f'\n[↑]({tweet_files[t.reply_to_id]}#s{t.reply_to_id})' if t.reply_to_id in tweet_files else '↑' |
There was a problem hiding this comment.
This breaks the new html output, sadly, since it links to an md file.
There was a problem hiding this comment.
@twoscomplement I'm thinking of rewriting the HTML output to be inside parser.py, produced alongside the markdown. This would make fixing this issue trivial. HTML is now produced alongside the MD.
|
@twoscomplement The links mostly seem to work in the md files, when viewed in Visual Studio Code at least. They take you to the right file but don't necessarily scroll down to the right place. |
|
I like that it doesn't change the order of the tweets. |
|
I'll look into reworking this once #67 is merged - might take me a few days |
lenaschimmel
changed the title
|
Hi @twoscomplement, are you still interested in finishing this PR? PR #67 is merged now. Is there anything we can do to assist? Or would you like someone else to take over your PR and finish it? Either way it's fine. (I also changed the title slightly, so it's not confused with multi-threaded implementation) |
|
Hi @lenaschimmel - thanks for asking, I've been short on time to revisit this. If there's someone else interested in picking this up, I'd be happy for them to do so - and happy to to cheer and/or review the work 🙂 |
For consideration/discussion wrt issue #23
(I'm not sure of the method of linking is actually useful - id's and filenames are valid, but may need to be expressed differently to work as intended in practice)