Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output all attached images #31

Merged

Conversation

twoscomplement
Copy link
Collaborator

A fix for #27

parser.py Show resolved Hide resolved
parser.py Outdated Show resolved Hide resolved
@Sjors
Copy link

Sjors commented Nov 13, 2022

In case I want to test this, is it safe to run the parser.py script twice?

@timhutton
Copy link
Owner

@Sjors parser.py doesn't change the archive, so you can run it as much as you want.

@Sjors
Copy link

Sjors commented Nov 13, 2022

@timhutton not the original archive, but is it also careful to not override expanded short URL's in the markdown files? (you never know when these short URL services disappear)

@timhutton
Copy link
Owner

@Sjors It completely overwrites the md when it runs. If you have edited the md since then you will lose those changes.

@Sjors
Copy link

Sjors commented Nov 13, 2022

Oh wait, I just realised you're just using the expanded_url field that Twitter provides. That won't work for very old tweets, but that's an unrelated issue.

parser.py Outdated Show resolved Hide resolved
parser.py Outdated Show resolved Hide resolved
@timhutton timhutton merged commit 91c9452 into timhutton:main Nov 13, 2022
@timhutton
Copy link
Owner

Works great, thanks @twoscomplement !

@timhutton
Copy link
Owner

@Sjors What do you mean "won't work for very old tweets"? Is expanded_url not available for old tweets?

@twoscomplement twoscomplement deleted the twoscomplement-multiple-images branch November 14, 2022 00:48
@Sjors
Copy link

Sjors commented Nov 14, 2022

Is expanded_url not available for old tweets?

Yes, see #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants