Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Timeplusd #2

Merged
merged 22 commits into from
Jul 26, 2024
Merged

support Timeplusd #2

merged 22 commits into from
Jul 26, 2024

Conversation

qijun-niu-timeplus
Copy link
Collaborator

No description provided.

@Jax-YHH Jax-YHH marked this pull request as ready for review July 24, 2024 08:46
mrssss and others added 17 commits July 24, 2024 17:57
1 The logic for detecting overflow during addition and multiplication in decimal.cpp has been revised.
2 The Int128 type has been globally updated across the project.
  The previously used absl library has been deprecated in favor of proton's wide::Integer.
3 The logic of some unit tests (UT) has been modified.
@Jax-YHH Jax-YHH force-pushed the feature/issue-1-support-timeplusd branch from 783327d to e36603d Compare July 24, 2024 10:04
@Jax-YHH Jax-YHH self-assigned this Jul 24, 2024
@Jax-YHH Jax-YHH requested review from yl-lisen and Jax-YHH July 25, 2024 06:43
@Jax-YHH Jax-YHH self-requested a review July 25, 2024 07:39
Copy link
Contributor

@Jax-YHH Jax-YHH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix overflow function bug in decimal.cpp.
Now the client can not append very large decimal data (in string form).

@yl-lisen yl-lisen changed the title cmake examples support Timeplusd Jul 25, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/main.cpp Outdated Show resolved Hide resolved
tests/simple/main.cpp Outdated Show resolved Hide resolved
timeplus/client.cpp Outdated Show resolved Hide resolved
timeplus/client.cpp Outdated Show resolved Hide resolved
timeplus/client.cpp Outdated Show resolved Hide resolved
timeplus/client.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@Jax-YHH Jax-YHH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finish code review

@Jax-YHH Jax-YHH merged commit 361ceb7 into master Jul 26, 2024
@Jax-YHH Jax-YHH mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants