-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Timeplusd #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 The logic for detecting overflow during addition and multiplication in decimal.cpp has been revised. 2 The Int128 type has been globally updated across the project. The previously used absl library has been deprecated in favor of proton's wide::Integer. 3 The logic of some unit tests (UT) has been modified.
Jax-YHH
force-pushed
the
feature/issue-1-support-timeplusd
branch
from
July 24, 2024 10:04
783327d
to
e36603d
Compare
Jax-YHH
reviewed
Jul 25, 2024
Jax-YHH
reviewed
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix overflow function bug in decimal.cpp.
Now the client can not append very large decimal data (in string form).
yl-lisen
reviewed
Jul 25, 2024
yl-lisen
reviewed
Jul 25, 2024
yl-lisen
reviewed
Jul 25, 2024
yl-lisen
reviewed
Jul 25, 2024
yl-lisen
reviewed
Jul 25, 2024
yl-lisen
reviewed
Jul 25, 2024
yl-lisen
reviewed
Jul 25, 2024
yl-lisen
reviewed
Jul 25, 2024
yl-lisen
reviewed
Jul 25, 2024
yl-lisen
reviewed
Jul 25, 2024
yl-lisen
reviewed
Jul 25, 2024
yl-lisen
reviewed
Jul 25, 2024
Jax-YHH
approved these changes
Jul 26, 2024
Jax-YHH
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finish code review
yl-lisen
approved these changes
Jul 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.