Standardise code and fix type error #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yibo-Chen13
changed the title
Yibo-Chen13
changed the title
Yibo-Chen13
force-pushed
the
fixed-bugs
branch
2 times, most recently
from
df39e30 to
ee25983
Compare
Yibo-Chen13
changed the title
Yibo-Chen13
force-pushed
the
fixed-bugs
branch
4 times, most recently
from
348c7bf to
7f212d0
Compare
proton_driver/columns/datecolumn.py
Outdated
| @@ -34,7 +34,7 @@ def before_write_items(self, items, nulls_map=None): | |||
| items[i] = null_value | |||
| continue | |||
|
|
|||
| if type(item) != date: | |||
| if item is not date: | |||
There was a problem hiding this comment.
isinstance(item, date)?
There was a problem hiding this comment.
Can't use isinstance here,datetime is a instance of date,that make a mistake.A more accurate approach uses type(item) is not date,I've modified it just now.
Yibo-Chen13
force-pushed
the
fixed-bugs
branch
2 times, most recently
from
2e68316 to
a1201eb
Compare
Yibo-Chen13
force-pushed
the
fixed-bugs
branch
from
a1201eb to
75e0ff0
Compare
yuzifeng1984
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.