Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toggle shortcut option and support tinykey keybindings #126

Closed
wants to merge 2 commits into from

Conversation

avigoldman
Copy link

Closes #55 and #121

@vercel
Copy link

vercel bot commented Nov 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/timc/kbar/GVRqXR62hYeBKrukCjMJ6MqU3gpZ
✅ Preview: https://kbar-git-fork-avigoldman-issue-55-timc.vercel.app

@avigoldman
Copy link
Author

There seems to be an issue with tinykeys not supporting special characters like ?. I did PR as a first pass to fix that issue here. jamiebuilds/tinykeys#131

@stale
Copy link

stale bot commented Nov 29, 2021

Hey! This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 29, 2021
@timc1 timc1 removed the wontfix This will not be worked on label Dec 1, 2021
@smhutch
Copy link
Contributor

smhutch commented Dec 13, 2021

@avigoldman @timc1 is there anything I could do to help with this PR? I'm working on a code editor, meaning we can't really use single character keyboard shortcuts (since we focus the editor in most cases 😄)

I would be happy to dedicate some time towards adding support for combinations like CMD + 1 or Ctrl + x etc. Any particular place I could help out here?

@timc1
Copy link
Owner

timc1 commented Dec 14, 2021

Hey @smhutch, we can get rid of the event.metaKey check here in the current implementation to get cmd/ctrl to work properly; however, we would need to add a few additional safeguards against registering cmd/ctrl+k.

I think it should be pretty straight forward; we originally added the event.metaKey as more of an easy solution. If you want to take a stab at removing it that would be great – I'll look into a solution as well tomorrow.

@stale
Copy link

stale bot commented Mar 24, 2022

Hey! This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 24, 2022
@timc1
Copy link
Owner

timc1 commented Mar 28, 2022

Closed as part of #185

@stale stale bot removed the wontfix This will not be worked on label Mar 28, 2022
@timc1 timc1 closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Developers to Configure Keyboard Shortcut (Instead of Cmd+K)
3 participants