Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Don't depend on uds.hex and udi.hex #313

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mchack-work
Copy link
Member

@mchack-work mchack-work commented Jan 20, 2025

Description

synth.json shouldn't depend on uds.hex and udi.hex because that triggers a complete rebuild of the bitstream if the UDI or UDS are changed.

Instead, we want only the application_fpga.asc target to depend on them, so it can patch in the changed UDS and UDI with tools/patch_uds_udi.py in an existing application_fpga_par.json.

Type of change

Please tick any that are relevant to this PR and remove any that aren't.

  • Bugfix (non breaking change which resolve an issue)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)
  • QEMU is updated to reflect changes

synth.json shouldn't depend on uds.hex and udi.hex because that
triggers a complete rebuild of the bitstream if the UDI or UDS are
changed.

Instead, we want only the application_fpga.asc to depend on them, so
we can patch in the UDS and UDI with tools/patch_uds_udi.py in an
existing application_fpga_par.json.
@mchack-work mchack-work requested a review from agren January 20, 2025 13:50
@agren
Copy link
Contributor

agren commented Jan 21, 2025

This looks good to me.

Doing an incremental build with updated UDI and UDS now works. The resulting application_fpga.bin is equivalent to application_fpga.bin built on main with the same UDI and UDS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants