Fix protobuf dependency invalid semver for cargo 1.54 for v0.5.x #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to sign off your commits. |
With this, rust-lang/cargo#9508, the dependency can no longer be used. What was picked with 1.53 cargo was ~2.0, so use that instead. Test: verify dependency can now be used Signed-off-by: Jean-Philippe DUFRAIGNE <[email protected]>
|
Thanks, Added the sign off line in the commit now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, rust-lang/cargo#9508, the dependency can no longer be used.
What was picked with 1.53 cargo was ~2.0, so use that instead.
This needs to be a new branch 0.5.1 that I branched from tag v0.5.0
Test:
Verify dependency can now be used.
protobuf in cargo.lock is unchanged in my dependent project.